More loader-config options#69
Open
Pizzabelly wants to merge 1 commit into
Open
Conversation
Fexty12573
reviewed
Jun 11, 2026
Comment on lines
+7
to
+16
| bool LogFile = true; | ||
| bool LogCmd = false; | ||
| std::string LogLevel = "ERROR"; | ||
| bool LogFile = false; | ||
| bool LogCmd = true; | ||
| std::string LogLevel = "INFO"; |
Contributor
Author
There was a problem hiding this comment.
I reverted the struct defaults back to what they were. Combined with the other changes in this PR, that is a change of behavior to now use the struct defaults when creating loader-config.json rather than the ConfigFile instance that was defined in the LoaderConfig constructor. If having separate defaults for the "file doesn't exist" path was the desired behavior, I can add that back too. The current behavior of this PR is that the struct defaults are always used unless something different is defined in the file. I've also changed the parsing logic to avoid crashing on a json that is malformed/empty or missing a value.
Pizzabelly
force-pushed
the
loader-config
branch
from
cc2ce48 to
6a281b6
Compare
Contributor
Author
|
This now also includes saving the config when the options are changed from the GUI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a way to set a list of which DLLs to preload that defaults to dinput8 (Stracker's Loader) and dxgi (ReShade). Also, more GUI options.